Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate away from yubico-specific struct names #24

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

louib
Copy link
Owner

@louib louib commented Feb 11, 2024

BREAKING CHANGE: The Yubikey struct was renamed to Device.
BREAKING CHANGE: The YubikeyError struct was renamed to ChallengeResponseError.
BREAKING CHANGE: The Yubico struct was renamed to ChallengeResponse.

@louib louib force-pushed the rename-structs branch 3 times, most recently from 150a882 to ceb609c Compare February 11, 2024 02:20
BREAKING CHANGE: The Yubikey struct was renamed to Device.
BREAKING CHANGE: The YubikeyError struct was renamed to ChallengeResponseError.
BREAKING CHANGE: The Yubico struct was renamed to ChallengeResponse.

Co-Authored-By: Ashutosh Verma <[email protected]>
@louib louib marked this pull request as ready for review February 11, 2024 02:23
@louib louib requested a review from ashuio as a code owner February 11, 2024 02:23
@louib louib merged commit f87a4c0 into master Feb 15, 2024
5 checks passed
@louib louib deleted the rename-structs branch February 15, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant