Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom payloads on device authority transfer #64

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

pojntfx
Copy link
Member

@pojntfx pojntfx commented Dec 17, 2024

This adds support for sending and receiving custom payloads on device authority transfers through OnBeforeSendDeviceAuthority and OnRemoteDeviceAuthorityReceived, which makes it possible to transfer instance metadata through the Silo event system in a single RTT.

… authority transfers through `OnBeforeSendDeviceAuthority` and `OnRemoteDeviceAuthorityReceived`

Signed-off-by: Felicitas Pojtinger <[email protected]>
@pojntfx pojntfx self-assigned this Dec 17, 2024
Copy link
Contributor

@jimmyaxod jimmyaxod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will keep support in the refactor I'm doing.
Currently drafter is doing one of the authorityTransfer events PER device. As part of the refactor I will change that to do a single transfer packet for the device group.

cmd/drafter-mounter/main.go Outdated Show resolved Hide resolved
@pojntfx
Copy link
Member Author

pojntfx commented Dec 18, 2024

Currently drafter is doing one of the authorityTransfer events PER device. As part of the refactor I will change that to do a single transfer packet for the device group.

Great, yeah that is what I originally intended here as well but without the duplicate events this is even better ^^

@pojntfx pojntfx merged commit a96530e into main Dec 18, 2024
48 checks passed
@pojntfx pojntfx deleted the add-custom-payload-event-support branch December 18, 2024 00:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants