fixup! apply feedback

acceptance/repository-mysql/src/__tests__/mysql.datasource.ts

@@ -23,4 +23,5 @@ export const MYSQL_CONFIG: DataSourceOptions = {
 export const MYSQL_FEATURES: Partial<CrudConnectorFeatures> = {
   idType: 'number',
   freeFormProperties: false,
+  supportsTransactions: true,
 };

packages/repository-tests/package.json

@@ -13,7 +13,7 @@
     "build": "lb-tsc",
     "clean": "lb-clean loopback-repository-tests*.tgz dist tsconfig.build.tsbuildinfo package",
     "pretest": "npm run build",
-    "test": "lb-mocha \"dist/__tests__/**/*.js\" --reporter=spec",
+    "test": "lb-mocha \"dist/__tests__/**/*.js\"",
     "verify": "npm pack && tar xf loopback-repository*.tgz && tree package && npm run clean"
   },
   "author": "IBM Corp.",

packages/repository-tests/src/crud/transactions.suite.ts

@@ -0,0 +1,132 @@
+// Copyright IBM Corp. 2019. All Rights Reserved.
+// Node module: @loopback/repository-tests
+// This file is licensed under the MIT License.
+// License text available at https://opensource.org/licenses/MIT
+
+import {
+  Entity,
+  IsolationLevel,
+  juggler,
+  model,
+  property,
+  TransactionalRepository,
+} from '@loopback/repository';
+import {expect, skipIf, toJSON} from '@loopback/testlab';
+import {Suite} from 'mocha';
+import {withCrudCtx} from '../helpers.repository-tests';
+import {
+  CrudConnectorFeatures,
+  CrudTestContext,
+  DataSourceOptions,
+  TransactionalRepositoryCtor,
+} from '../types.repository-tests';
+
+// Core scenarios for testing CRUD functionalities of Transactional connectors
+// Please keep this file short, put any advanced scenarios to other files
+export function transactionSuite(
+  dataSourceOptions: DataSourceOptions,
+  repositoryClass: TransactionalRepositoryCtor,
+  connectorFeatures: CrudConnectorFeatures,
+) {
+  skipIf<[(this: Suite) => void], void>(
+    !connectorFeatures.supportsTransactions,
+    describe,
+    `transactions`,
+    () => {
+      @model()
+      class Product extends Entity {
+        @property({
+          type: connectorFeatures.idType,
+          id: true,
+          generated: true,
+          description: 'The unique identifier for a product',
+        })
+        id: number | string;
+
+        @property({type: 'string', required: true})
+        name: string;
+
+        constructor(data?: Partial<Product>) {
+          super(data);
+        }
+      }
+
+      describe('create-retrieve with transactions', () => {
+        let repo: TransactionalRepository<Product, typeof Product.prototype.id>;
+        before(
+          withCrudCtx(async function setupRepository(ctx: CrudTestContext) {
+            repo = new repositoryClass(Product, ctx.dataSource);
+            await ctx.dataSource.automigrate(Product.name);
+          }),
+        );
+
+        it('retrieves model instance once transaction is committed', async () => {
+          const tx: juggler.Transaction = await repo.beginTransaction({
+            isolationLevel: IsolationLevel.READ_COMMITTED,
+          });
+          const created = await repo.create(
+            {name: 'Pencil'},
+            {transaction: tx},
+          );
+          expect(created.toObject()).to.have.properties('id', 'name');
+          expect(created.id).to.be.ok();
+
+          await tx.commit();
+          const foundOutsideTransaction = await repo.findById(created.id, {});
+          expect(toJSON(created)).to.deepEqual(toJSON(foundOutsideTransaction));
+        });
+
+        it('can rollback transaction', async () => {
+          const tx: juggler.Transaction = await repo.beginTransaction({
+            isolationLevel: IsolationLevel.READ_COMMITTED,
+          });
+          const created = await repo.create(
+            {name: 'Pencil'},
+            {transaction: tx},
+          );
+          expect(created.toObject()).to.have.properties('id', 'name');
+          expect(created.id).to.be.ok();
+
+          const foundInsideTransaction = await repo.findById(
+            created.id,
+            {},
+            {
+              transaction: tx,
+            },
+          );
+          expect(toJSON(created)).to.deepEqual(toJSON(foundInsideTransaction));
+          await tx.rollback();
+          await expect(repo.findById(created.id, {})).to.be.rejectedWith({
+            code: 'ENTITY_NOT_FOUND',
+            message: /Entity not found/,
+          });
+        });
+
+        it('ensures transactions are isolated', async () => {
+          const tx: juggler.Transaction = await repo.beginTransaction({
+            isolationLevel: IsolationLevel.READ_COMMITTED,
+          });
+          const created = await repo.create(
+            {name: 'Pencil'},
+            {transaction: tx},
+          );
+          expect(created.toObject()).to.have.properties('id', 'name');
+          expect(created.id).to.be.ok();
+
+          const foundInsideTransaction = await repo.findById(
+            created.id,
+            {},
+            {
+              transaction: tx,
+            },
+          );
+          expect(toJSON(created)).to.deepEqual(toJSON(foundInsideTransaction));
+          await expect(repo.findById(created.id, {})).to.be.rejectedWith({
+            code: 'ENTITY_NOT_FOUND',
+            message: /Entity not found/,
+          });
+        });
+      });
+    },
+  );
+}

packages/repository-tests/src/index.ts

@@ -4,7 +4,6 @@
 // License text available at https://opensource.org/licenses/MIT
 
 export * from './crud-test-suite';
-export * from './transaction-test-suite';
 export * from './types.repository-tests';
 
 // TODO(bajtos) Implement test suite for KeyValue repository