feat(console,core): enable configure on nameIdFormat and encryption #6929
+314
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
wangsijie,
charIeszhao,
xiaoyijun and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/console/src/ds-components/Textarea/index.module.scss | 📈 +175 Bytes |
| packages/console/src/ds-components/Textarea/index.tsx | 📈 +146 Bytes |
| packages/console/src/pages/ApplicationDetails/SamlApplicationDetailsContent/Settings.tsx | 📈 +4.16 KB |
| packages/console/src/pages/ApplicationDetails/SamlApplicationDetailsContent/index.module.scss | 📈 +102 Bytes |
| packages/console/src/pages/ApplicationDetails/SamlApplicationDetailsContent/utils.ts | 📈 +1.49 KB |
| packages/core/src/saml-applications/SamlApplication/index.test.ts | 📈 +90 Bytes |
| packages/core/src/saml-applications/SamlApplication/index.ts | 📈 +865 Bytes |
| packages/core/src/saml-applications/SamlApplication/utils.test.ts | 📈 +133 Bytes |
| packages/core/src/saml-applications/SamlApplication/utils.ts | 📈 +99 Bytes |
| packages/core/src/saml-applications/queries/index.ts | 📈 +216 Bytes |
| packages/phrases/src/locales/en/errors/application.ts | 📈 +259 Bytes |
| packages/phrases/src/locales/en/translation/admin-console/application-details.ts | 📈 +1.36 KB |
darcyYe
changed the title
charIeszhao
reviewed
Jan 8, 2025
packages/console/src/pages/ApplicationDetails/SamlApplicationDetailsContent/Settings.tsx
Outdated
Show resolved
Hide resolved
charIeszhao
reviewed
Jan 8, 2025
packages/console/src/pages/ApplicationDetails/SamlApplicationDetailsContent/Settings.tsx
Outdated
Show resolved
Hide resolved
charIeszhao
approved these changes
Jan 8, 2025
darcyYe
force-pushed
the
yemq-enable-configure-on-name-id-format-and-encryption
branch
from
03b305a to
8178b64
Compare
darcyYe
force-pushed
the
yemq-enable-configure-on-name-id-format-and-encryption
branch
from
8178b64 to
a411973
Compare
wangsijie
approved these changes
Jan 8, 2025
darcyYe
deleted the
yemq-enable-configure-on-name-id-format-and-encryption
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nameIdFormatandencryptionthrough console. (resolves LOG-10673)nameIdFormatandencryptioncan take affect on SAML app flow. (resolves LOG-10671)Testing
Tested locally.
Checklist
.changeset