fix(core): fix create org role API #6894
Open
+143
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
simeng-li,
wangsijie and
gao-sun
as code owners
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/thick-baboons-sniff.md | 📈 +214 Bytes |
| packages/core/src/routes/organization-role/index.openapi.json | 📈 +167 Bytes |
| packages/core/src/routes/organization-role/index.ts | 📈 +877 Bytes |
| packages/integration-tests/src/tests/api/organization/organization-role.test.ts | 📈 +2.88 KB |
| packages/phrases/src/locales/en/errors/organization.ts | 📈 +157 Bytes |
darcyYe
force-pushed
the
yemq-fix-post-org-roles-API
branch
from
8c98e1a to
2c73686
Compare
4 tasks
darcyYe
force-pushed
the
yemq-fix-post-org-roles-API
branch
from
2c73686 to
bdebf2a
Compare
|
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
CI failed |
darcyYe
force-pushed
the
yemq-fix-post-org-roles-API
branch
from
bdebf2a to
3eb6413
Compare
wangsijie
approved these changes
Jan 21, 2025
darcyYe
force-pushed
the
yemq-fix-post-org-roles-API
branch
from
3eb6413 to
3d004de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix create org role API:
Previously, if
organizationScopeIdsorresourceScopeIdscontained an invalid ID (such as a non-existent scope ID), the API would return a 4xx error, but the role would still be created. In reality, the role should not have been created.Repored by community users in issue 6891.
Testing
Add integration tests to cover these scenarios.
Checklist
.changeset