Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for src/config/app.ts #5914

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

gru-agent[bot]
Copy link
Contributor

@gru-agent gru-agent bot commented Feb 8, 2025

Trigger Info

Trigger Type Triggered By Source Pull Request Assignment
Auto Rebase arvinxx 5910 Detail

Summary

Summary

This PR introduces unit tests for the app.ts configuration module, ensuring the correctness of environment variable parsing and default value handling. Key changes include:

  • Unit Tests for getAppConfig:

    • Validates default configuration values.

    • Tests parsing of ACCESS_CODE and other environment variables.

    • Ensures proper handling of boolean flags and custom font settings.

  • Unit Tests for URL Constants:

    • Verifies vercelUrl and APP_URL behavior based on environment variables.

    • Confirms detection of the Vercel environment.

  • Exports:

    • Adds explicit exports for APP_URL, ASSISTANT_INDEX_URL, isInVercel, PLUGINS_INDEX_URL, and vercelUrl from app.ts.

These tests enhance the reliability of the configuration module by covering various scenarios and edge cases.

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Tip

You can @gru-agent rebase to rebase the PR.

Tip

You can @gru-agent redo to reset or rebase before redoing the PR.

Tip

To modify the test code yourself, click here Edit Test Code

@gru-agent gru-agent bot requested a review from arvinxx February 8, 2025 23:05
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 8, 2025
Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-database 🛑 Canceled (Inspect) Feb 9, 2025 4:12am
lobe-chat-preview 🛑 Canceled (Inspect) Feb 9, 2025 4:12am

@lobehubbot
Copy link
Member

👍 @gru-agent[bot]

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.13%. Comparing base (cbc5967) to head (e7e46d5).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5914   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files         650      650           
  Lines       59053    59059    +6     
  Branches     2925     2926    +1     
=======================================
+ Hits        54406    54412    +6     
  Misses       4647     4647           
Flag Coverage Δ
app 92.13% <100.00%> (+<0.01%) ⬆️
server 98.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

gru-agent bot commented Feb 9, 2025

✅ Rebase TestGru PR Success

Type Change
Base Sha e5a1f47...a63a385
Head Sha 7e6c645...a842537

@gru-agent gru-agent bot force-pushed the testgru-src-config-app.ts-1739055938283 branch from 7e6c645 to a842537 Compare February 9, 2025 02:54
@vercel vercel bot temporarily deployed to Preview – lobe-chat-preview February 9, 2025 03:05 Inactive
@lobehub lobehub deleted a comment from lobehubbot Feb 9, 2025
Copy link
Contributor Author

gru-agent bot commented Feb 9, 2025

✅ Rebase TestGru PR Success

Type Change
Base Sha a63a385...9fa0f25
Head Sha a842537...bf26a55

@gru-agent gru-agent bot force-pushed the testgru-src-config-app.ts-1739055938283 branch from a842537 to bf26a55 Compare February 9, 2025 03:12
@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


🔄 Rebasing Testgru per ...

Copy link
Contributor Author

gru-agent bot commented Feb 9, 2025

✅ Rebase TestGru PR Success

Type Change
Base Sha 9fa0f25...dd3ac56
Head Sha bf26a55...59f8055

@gru-agent gru-agent bot force-pushed the testgru-src-config-app.ts-1739055938283 branch from bf26a55 to 59f8055 Compare February 9, 2025 03:16
@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


🔄 Rebasing Testgru per ...

@vercel vercel bot temporarily deployed to Preview – lobe-chat-database February 9, 2025 03:36 Inactive
Copy link
Contributor Author

gru-agent bot commented Feb 9, 2025

✅ Rebase TestGru PR Success

Type Change
Base Sha dd3ac56...c71147f
Head Sha 59f8055...e7e46d5

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


🔄 Rebasing Testgru per ...

@gru-agent gru-agent bot force-pushed the testgru-src-config-app.ts-1739055938283 branch from 59f8055 to e7e46d5 Compare February 9, 2025 03:41
Copy link

vercel bot commented Feb 9, 2025

Deployment failed with the following error:

Resource is limited - try again in 1 minute (more than 100, code: "api-deployments-free-per-day").

Base automatically changed from perf/rewrite-local to main February 9, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants