Upgrade everything to its newest version, use PSR-12, support PHP 8.3 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D0L1K
requested review from
jirinovak,
kdosiodjinud,
MarketaSebkova,
vaclavbarta and
hokypierce
jirinovak
approved these changes
Apr 8, 2024
vaclavbarta
approved these changes
Apr 10, 2024
MarketaSebkova
approved these changes
Apr 10, 2024
OndraM
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Hi,
thanks, I tried it on one repo and so far so good 👍 . I still want to to go through the rules and fixers (so maybe I will add some more comments tomorrow if I found some issue), but I don't want to delay what I found so far.
Apart from the inline comments:
- The github actions build was disabled by github (because there wasn't activity in the repo...) and needs to be updated. I enabled it, but you need to push some changes to trigger the build... And expect it to fail.
- There are examples in the README.md, which are not updated to the new configuration
- There is a small grammar typo in commit message (
it's->its), could you please fix this when you will be rebasing the commit before merge?
Thanks!
D0L1K
force-pushed
the
feature/php8
branch
2 times, most recently
from
a748b08 to
dabd834
Compare
vaclavbarta
approved these changes
Apr 17, 2024
OndraM
requested changes
Apr 18, 2024
OndraM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.