fix: incomplete events #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing `boldAccrued` to `SnapshotVotes`. Add missing `vetos` to `SnapshotVotesForInitiative`. Add missing success flags when calling hooks. Add `indexed` to select events. Had to slightly refactor `_allocateLQTY()` to avoid running into "stack too deep". Fixes CS-V2Gov-040.
bingen
approved these changes
Dec 2, 2024
Sorry about that 😅 |
|
Ugh, it's not that easy, then I have to put a lot more stuff in memory and it gets even more expensive gas-wise. |
|
Closing in favor of #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
boldAccruedtoSnapshotVotes.Add missing
vetostoSnapshotVotesForInitiative.Add missing success flags when calling hooks.
Add
indexedto select parameters.Do call the
onRegisterInitiative()hook for initial initiatives.Had to slightly refactor
_allocateLQTY()to avoid running into "stack too deep".Fixes CS-V2Gov-040.