Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pin solidity version of main contracts to 0.8.24 #86

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

bingen
Copy link
Contributor

@bingen bingen commented Nov 26, 2024

Leave interfaces and utils floating, so they can be used by 3rd parties.

Leave interfaces and utils floating, so they can be used by 3rd parties.
@bingen bingen self-assigned this Nov 26, 2024
@danielattilasimon
Copy link
Contributor

danielattilasimon commented Nov 28, 2024

Just a heads up: we might run into some problems down the line. After updating the Uni v4 submodule to the latest version, the PoolManager contract requires Solidity == 0.8.26. Thus, there will be a conflict in UniV4Donations.t.sol, because it imports both our governance contracts (== 0.8.24) and PoolManager.

We could work around this by deploying PoolManager from bytecode.

Copy link
Contributor

@danielattilasimon danielattilasimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now, but there might be some issues with Uni v4 in the future.

@bingen bingen merged commit 49776e9 into main Nov 28, 2024
3 checks passed
@danielattilasimon danielattilasimon deleted the D-A8 branch January 19, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants