radio@driglu4it: add more debug information when youtube download fails #6802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on enhancing error handling and logging for YouTube download functionality in the
radio@driglu4itapplet. The changes involve passing thedownloadCommandto success and error callbacks, adding more detailed error messages, and providing users with options to view logs for troubleshooting.Enhancements to error handling and logging:
radio@driglu4it/files/radio@driglu4it/6.4/radio-applet.js: Modified thedownloadWithYouTubeDl,downloadWithYtDlp, anddownloadSongFromYouTubefunctions to pass thedownloadCommandto theonSuccesscallback. This allows better tracking of the command used during the download process. [1] [2] [3]radio@driglu4it/files/radio@driglu4it/6.4/radio-applet.js: Enhanced thenotifyYouTubeDownloadFailedfunction to include an additional button for viewing logs, providing users with more information for troubleshooting.radio@driglu4it/files/radio@driglu4it/6.4/radio-applet.js: Updated themoveFileFromTmpDirfunction to handle errors more gracefully by passing detailed error messages to theonErrorcallback. [1] [2] [3]