Skip to content

Add the `uid` option for elasticsearch; support ansible-core; improve performance; fix multi-line ansible_managed

Compare
Choose a tag to compare
@spetrosi spetrosi released this 05 Oct 12:34

test new version of tox-lsr

try py29

try official 2.5.0

use 2.5.1

We want to expose the uid and pwd parameters in our role,

to allow basic auth on the elasticsearch server.

The metrics update can be seen here: https://gerrit.ovirt.org/#/c/ovirt-engine-metrics/+/116098/

Bug-Url: https://bugzilla.redhat.com/1990490

Signed-off-by: Aviv Litman [email protected]

- Replacing the seport module with the semanage command line.

  • Adding policycoreutils-python for rhel-7/centos-7 or
    policycoreutils-python-utils for the others to __rsyslog_ovirt_prereq_packages.

Use the openssl command-line interface instead of the openssl module

in the test helper task tests/tasks/create_tests_certs.yml.

This is to avoid using the non ansible-core module.

Eliminating redundant loop.

When including an input or an output subrole, it is called with
one configuration item (not with the list). Thus, it should not
loop on the logging_inputs or logging_outputs items in the sub-
role task. This commit removes the loops and updated templates
according to the change.

Note: the basic input generates only one basic input conf file.

If multiple items having basics type are accidentally defined:
logging_inputs:
- name: basic_input0
type: basics
- name: basic_input1
type: basics
only the first item is used to generate ##-basic_input0.conf and
the rest (in this example, basic_input1) is ignored.

use apt-get install -y

Signed-off-by: Rich Megginson [email protected]

Use {{ ansible_managed | comment }} to fix multi-line ansible_managed

BZ#2006230, BZ#2006231, BZ#2006233

Generate test files with the new Ansible managed comment format

Performance improvement

  • Eliminating unnecessary set_fact tasks in tasks/main.yml and moving
    them to the individual input and output.
  • Eliminating unnecessary loop for the set_certs tasks.
  • Fixing a typo and applying the set_certs changes to tests_ovirt_elasticsearch.yml
    and tests_files_elasticsearch.yml.
  • Replacing variable names starting with one underscore with two.
  • Initializing rsyslog_inputs and rsyslog_outputs with [].