Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove name="basics_imuxsock" parameter from imuxsock type input #385

Merged
merged 1 commit into from
May 10, 2024

Conversation

spetrosi
Copy link
Contributor

@spetrosi spetrosi commented May 7, 2024

Cause: The role set a name parameter for the imuxsock input type.
Consequence: This input type does not support the "name" parameter. rsyslog was printing the error: parameter 'name' not known -- typo in config file?
Fix: Do not set a name parameter for the imuxsock input type.
Jira: RHEL-35561

@spetrosi
Copy link
Contributor Author

spetrosi commented May 7, 2024

[citest]

@spetrosi
Copy link
Contributor Author

spetrosi commented May 7, 2024

I checked the role running other modules that use name as input parameter too, this error does not occur anywhere else.
As per https://rsyslog-doc-v5.readthedocs.io/en/latest/configuration/modules/imuxsock.html name parameter is not supported

@spetrosi spetrosi force-pushed the imuxsock-remove-name branch from 0b023eb to 126e6c3 Compare May 7, 2024 21:54
@spetrosi
Copy link
Contributor Author

spetrosi commented May 7, 2024

[citest]

@richm
Copy link
Collaborator

richm commented May 8, 2024

Do not append input_template.j2 when use_imuxsock

I don't see this in the patch?

@spetrosi spetrosi force-pushed the imuxsock-remove-name branch from 126e6c3 to 4f79a3c Compare May 9, 2024 13:43
@spetrosi
Copy link
Contributor Author

spetrosi commented May 9, 2024

[citest]

- Input of type imuxsock does not support the "name" parameter.
  When name is provided, rsyslog ouputs this error:
  parameter 'name' not known -- typo in config file?
- Indend "if" expressions for style

See RHEL-35561
@spetrosi spetrosi force-pushed the imuxsock-remove-name branch from 4f79a3c to 88ad78f Compare May 9, 2024 17:52
@spetrosi
Copy link
Contributor Author

spetrosi commented May 9, 2024

[citest]

@richm richm merged commit a3f9e5c into linux-system-roles:main May 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants