Fix silent failure when ingesting an Asset with an unrecognized field #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #481 +/- ##
============================================
+ Coverage 66.21% 66.25% +0.03%
- Complexity 1531 1532 +1
============================================
Files 137 137
Lines 5888 5889 +1
Branches 653 653
============================================
+ Hits 3899 3902 +3
+ Misses 1711 1710 -1
+ Partials 278 277 -1 ☔ View full report in Codecov by Sentry. |
yangyangv2
reviewed
Nov 27, 2024
| */ | ||
| public static void validateAgainstSchema(@Nonnull RecordTemplate model) { | ||
| ValidationResult result = ValidateDataAgainstSchema.validate(model, | ||
| new ValidationOptions(RequiredMode.CAN_BE_ABSENT_IF_HAS_DEFAULT, CoercionMode.NORMAL, |
There was a problem hiding this comment.
can ValidationOptions be a constant? or it has to be instantiated every time?
yangyangv2
reviewed
Nov 27, 2024
| new ValidationOptions(RequiredMode.CAN_BE_ABSENT_IF_HAS_DEFAULT, CoercionMode.NORMAL, | ||
| UnrecognizedFieldMode.DISALLOW)); | ||
| if (!result.isValid()) { | ||
| invalidSchema(result.getMessages().toString()); |
There was a problem hiding this comment.
using String.valueOf(result.getMessages()) to avoid NPE?
yangyangv2
reviewed
Nov 27, 2024
yangyangv2
reviewed
Nov 27, 2024
| @@ -46,6 +46,9 @@ public final class ValidationUtils { | |||
|
|
|||
| private static final Map<String, String> SOFT_DELETED_FIELD_METADATA = fieldMetadata(new SoftDeletedAspect().schema()); | |||
|
|
|||
| public static final ValidationOptions VALIDATION_OPTIONS = | |||
There was a problem hiding this comment.
minor: make it private if not used in other class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BUG=META-21242
This PR adds Restli model validation to the Asset ingestion endpoints to throw errors in these otherwise silent-failure cases:
Testing Done
Added unit testing for both:
Checklist