Refactor to have a common interface for InUpdate Callback #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #451 +/- ##
============================================
- Coverage 67.59% 67.52% -0.07%
- Complexity 1572 1581 +9
============================================
Files 142 142
Lines 6125 6159 +34
Branches 660 667 +7
============================================
+ Hits 4140 4159 +19
- Misses 1706 1717 +11
- Partials 279 283 +4 ☔ View full report in Codecov by Sentry. |
ZihanLi58
reviewed
Oct 16, 2024
dao-api/src/main/java/com/linkedin/metadata/dao/BaseLocalDAO.java
Outdated
Show resolved
Hide resolved
dao-api/src/main/java/com/linkedin/metadata/dao/BaseLocalDAO.java
Outdated
Show resolved
Hide resolved
| */ | ||
| @Data | ||
| public class PreUpdateResponse<ASPECT extends RecordTemplate> { | ||
| public class InUpdateResponse<ASPECT extends RecordTemplate> { |
There was a problem hiding this comment.
Why do we need this Response class here instead of just return aspect? Are we planning to add more field in the future?
There was a problem hiding this comment.
Yes. For SourceLineage Ingestion Hook, MM team needs Auditstamp as part of response as well. More details: https://docs.google.com/document/d/1PlPPb4gHJYCViH9pcuwChVoiJDcmll-_1yREvoG3iCI/edit
restli-resources/src/main/java/com/linkedin/metadata/restli/BaseEntityResource.java
Outdated
Show resolved
Hide resolved
restli-resources/src/main/java/com/linkedin/metadata/restli/BaseAspectRoutingResource.java
Outdated
Show resolved
Hide resolved
yihzhou
reviewed
Oct 16, 2024
dao-api/src/main/java/com/linkedin/metadata/dao/BaseLocalDAO.java
Outdated
Show resolved
Hide resolved
rakhiagr
changed the title
ZihanLi58
reviewed
Oct 16, 2024
dao-api/src/main/java/com/linkedin/metadata/dao/BaseLocalDAO.java
Outdated
Show resolved
Hide resolved
| @@ -610,7 +618,7 @@ public List<ASPECT_UNION> addMany(@Nonnull URN urn, @Nonnull List<? extends Reco | |||
| } | |||
|
|
|||
| private <ASPECT extends RecordTemplate> AddResult<ASPECT> aspectUpdateHelper(URN urn, AspectUpdateLambda<ASPECT> updateTuple, | |||
| @Nonnull AuditStamp auditStamp, @Nullable IngestionTrackingContext trackingContext) { | |||
| @Nonnull AuditStamp auditStamp, @Nullable IngestionTrackingContext trackingContext, boolean inSkipUpdate) { | |||
| @@ -831,8 +846,8 @@ public <ASPECT extends RecordTemplate> ASPECT add(@Nonnull URN urn, @Nonnull Cla | |||
| @Nonnull | |||
| public <ASPECT extends RecordTemplate> ASPECT add(@Nonnull URN urn, @Nonnull Class<ASPECT> aspectClass, | |||
| @Nonnull Function<Optional<ASPECT>, ASPECT> updateLambda, @Nonnull AuditStamp auditStamp, | |||
| @Nullable IngestionTrackingContext trackingContext, @Nonnull IngestionParams ingestionParams) { | |||
| return add(urn, aspectClass, updateLambda, auditStamp, DEFAULT_MAX_TRANSACTION_RETRY, trackingContext, ingestionParams); | |||
| @Nullable IngestionTrackingContext trackingContext, @Nonnull IngestionParams ingestionParams, boolean inSkipUpdate) { | |||
There was a problem hiding this comment.
same here, I hope raw update is the only place where we will set the flag to be true
dao-api/src/main/java/com/linkedin/metadata/dao/BaseLocalDAO.java
Outdated
Show resolved
Hide resolved
dao-api/src/main/java/com/linkedin/metadata/dao/BaseLocalDAO.java
Outdated
Show resolved
Hide resolved
jsdonn
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For this pull request, we have refactored the codebase to have a common interface for InUpdate Callback. This interface can be used for both Restli implementation (DatasetAccountableOwnership aspect) and gRPC implementations (Asset classes). Refactored the callback operation from the top of stack add method to the bottom most updateAspectHelper method to leverage the transactions and retry mechanism.
We still need the rawAdd method to skip the callbacks(routing) for cases where the ingestion request is routed to a client and comes back for ingestion to local DAO (Known case: AccountableOwnership uses rawAdd for dual write).
Testing Done
mint build
Unit tests added
Checklist