Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Read column from aspect-alias instead of column annotation - part 1 #433

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

yangyangv2
Copy link
Contributor

Summary

Read column from aspect-alias instead of column annotation - part 1

This is Part 1 of the work, which takes additional parameter (assetType aka entityType) into the getAspectColumn method.

Part 2 of the work will be implementing a map which retrieve aspect-alias by assetType and aspect class

Testing Done

./gradlew build

Checklist

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 92.68293% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.49%. Comparing base (0d7727e) to head (764914d).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...com/linkedin/metadata/dao/utils/EBeanDAOUtils.java 50.00% 2 Missing ⚠️
...linkedin/metadata/dao/utils/SQLStatementUtils.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #433      +/-   ##
============================================
+ Coverage     67.48%   67.49%   +0.01%     
- Complexity     1527     1528       +1     
============================================
  Files           137      137              
  Lines          5991     5999       +8     
  Branches        646      648       +2     
============================================
+ Hits           4043     4049       +6     
- Misses         1672     1673       +1     
- Partials        276      277       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jsdonn jsdonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't wait for part 2!

@yangyangv2 yangyangv2 merged commit 3f21e7c into master Sep 26, 2024
2 checks passed
@yangyangv2 yangyangv2 changed the title Read column from aspect-alias instead of column annotation - part 1 [feat] Read column from aspect-alias instead of column annotation - part 1 Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants