Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update EbeanLocalDao constuctors with urnClass & minor update #331

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix: update EbeanLocalDao constuctors with urnClass & minor update #331

merged 2 commits into from
Dec 5, 2023

Conversation

JiaoMaWHU
Copy link
Contributor

@JiaoMaWHU JiaoMaWHU commented Dec 5, 2023 •
edited
Loading

Summary

  • BaseLocalDao has four constructors and 2 dependencies: EbeanLocalDao and EspressoDao (not in this repo).
  • it turns out the rest two constructors in BaseLocalDao are also used in EbeanLocalDao in dao factory, therefore this PR updates remaining constructors with urnClass

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@JiaoMaWHU JiaoMaWHU self-assigned this Dec 5, 2023
@JiaoMaWHU JiaoMaWHU requested a review from jsdonn December 5, 2023 01:18
@JiaoMaWHU JiaoMaWHU marked this pull request as ready for review December 5, 2023 01:25
jsdonn
jsdonn reviewed Dec 5, 2023
View reviewed changes
dao-api/src/main/java/com/linkedin/metadata/dao/BaseLocalDAO.java
*/
public BaseLocalDAO(@Nonnull BaseMetadataEventProducer producer, @Nonnull LocalDAOStorageConfig storageConfig) {
public BaseLocalDAO(@Nonnull BaseMetadataEventProducer producer, @Nonnull LocalDAOStorageConfig storageConfig,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this break any existing constructor calls? i.e. are these constructors in use by anyone? If so they will have to update right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No in my theory. Basically BaseLocalDao only has 2 implementations: EbeanLocalDao and EspressoDao (not in this repo).

The constructor used in EspressoDao was already updated.

In EbeanLocalDao, all the super.constructor() will be updated after this PR.

I don't think there is any other dependency on BaseLocalDao. WDYT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for explaining

jsdonn
jsdonn approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@jsdonn jsdonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiaoMaWHU JiaoMaWHU merged commit 5d21530 into master Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdonn jsdonn jsdonn approved these changes

Assignees

@JiaoMaWHU JiaoMaWHU

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiaoMaWHU @jsdonn