Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update backfillMAE API signature #330

Merged
merged 2 commits into from
Dec 4, 2023
Merged

refactor: update backfillMAE API signature #330

merged 2 commits into from
Dec 4, 2023

Conversation

JiaoMaWHU
Copy link
Contributor

Summary

  • change List<BackfillItem> to BackfillItem[] in method signature since collection is not supported by rest.li
  • wrap Task around BackfillItem[] in order to support aync call

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@JiaoMaWHU JiaoMaWHU self-assigned this Dec 4, 2023
@JiaoMaWHU JiaoMaWHU marked this pull request as ready for review December 4, 2023 04:26
@JiaoMaWHU JiaoMaWHU requested a review from yangyangv2 December 4, 2023 04:26
yangyangv2
yangyangv2 reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@yangyangv2 yangyangv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yangyangv2
yangyangv2 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@yangyangv2 yangyangv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch with the restli restriction!

@JiaoMaWHU JiaoMaWHU merged commit 80da721 into master Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangyangv2 yangyangv2 yangyangv2 approved these changes

Assignees

@JiaoMaWHU JiaoMaWHU

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiaoMaWHU @yangyangv2