fix(new schema): read metadata_aspect during getLatest regardless of schema mode #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug with a recent PR #298 which is causing OptimisticLockException to be thrown. Essentially, getLatest is reading from the new schema (in new schema only mode) but updateWithOptimisticLocking is trying to apply optimistic locking on the old schema table using the timestamp returned from the getLatest call on the entity table. The timestamps in the old and new schema tables may be off by a few ms so the update will fail during timestamp comparation.
This PR aims to revert part of that PR by reading the old schema table during getLatest always UNLESS change log is disabled.
Checklist