feat: add action emitNoChangeMetadataAuditEvent & add ingestionMode in mae #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaoMaWHU
requested review from
jsdonn and
yangyangv2
and removed request for
jsdonn
jsdonn
reviewed
Oct 19, 2023
dao-impl/ebean-dao/src/test/java/com/linkedin/metadata/dao/EbeanLocalDAOTest.java
Show resolved
Hide resolved
| verify(_mockProducer, times(1)).produceMetadataAuditEvent(urn, null, aspect); | ||
| verify(_mockProducer, times(1)).produceAspectSpecificMetadataAuditEvent(urn, null, aspect, null); | ||
| verify(_mockProducer, times(0)).produceMetadataAuditEvent(urn, aspect, aspect); | ||
| verify(_mockProducer, times(0)).produceAspectSpecificMetadataAuditEvent(urn, aspect, aspect, null); |
There was a problem hiding this comment.
also not this line, but I see line 908/911 still have mentions of MAE_ONLY_WITH_OLD_VALUE_NULL. Want to remove those (and elsewhere)?
There was a problem hiding this comment.
you think it makes more sense to remove it instead of having ut verifying it? I intended to keep it because I won't remove it from the enum, so want to remind ppl that do not use it.
jsdonn
reviewed
Oct 19, 2023
| @@ -24,4 +24,10 @@ enum BackfillMode { | |||
| * Backfill only using MAE. Setting the old value in MAE payload as null. | |||
| */ | |||
| MAE_ONLY_WITH_OLD_VALUE_NULL | |||
There was a problem hiding this comment.
Can you add something here about the deprecation + not to use it
jsdonn
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
emitNoChangeMetadataAuditEventaction with ingestionMode to support backfill into both live and backup index.backfillWithNewValueactionChecklist