Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelixBootstrapUpgradeTool: add FULL AUTO values to instances config #2614

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

justinlin-linkedin
Copy link
Collaborator

When there is a resource in helix cluster, that is already turned FULL AUTO on, we have to also add the FULL AUTO compatible values to the new instances when they are added to the other resources.
This PR fixes that.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d878bb7) 70.29% compared to head (dacabf1) 72.22%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2614      +/-   ##
============================================
+ Coverage     70.29%   72.22%   +1.93%     
- Complexity    11124    11409     +285     
============================================
  Files           806      806              
  Lines         65158    65179      +21     
  Branches       7940     7942       +2     
============================================
+ Hits          45800    47075    +1275     
+ Misses        16761    15521    -1240     
+ Partials       2597     2583      -14     
Files Coverage Δ
...ub/ambry/clustermap/HelixBootstrapUpgradeUtil.java 73.06% <100.00%> (+0.48%) ⬆️

... and 100 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinlin-linkedin justinlin-linkedin merged commit 302abbe into linkedin:master Oct 12, 2023
5 checks passed
@justinlin-linkedin justinlin-linkedin deleted the justin/tool branch October 12, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants