Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelixBootstrapTool: add prompt before remove #2608

Merged

Conversation

justinlin-linkedin
Copy link
Collaborator

Summary

Prompt user to confirm the delete before actually deleting the instance or resource.

@codecov-commenter
Copy link

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (15e7dfa) 72.24% compared to head (c101716) 72.19%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2608      +/-   ##
============================================
- Coverage     72.24%   72.19%   -0.06%     
- Complexity    11407    11410       +3     
============================================
  Files           805      806       +1     
  Lines         65097    65139      +42     
  Branches       7936     7945       +9     
============================================
- Hits          47030    47027       -3     
- Misses        15484    15521      +37     
- Partials       2583     2591       +8     
Files Coverage Δ
...ub/ambry/clustermap/HelixBootstrapUpgradeTool.java 0.00% <0.00%> (ø)
...ub/ambry/clustermap/HelixBootstrapUpgradeUtil.java 72.40% <24.00%> (-0.77%) ⬇️

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinlin-linkedin justinlin-linkedin merged commit 4f50807 into linkedin:master Oct 6, 2023
@justinlin-linkedin justinlin-linkedin deleted the justin/hotfixbootstrap branch October 6, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants