While detecting Username and password in url we were not breaking the… (

#31)

* While detecting Username and password in url we were not breaking the iteration if we find the :
This meanst that if there was a long substring of : then we will iterate till the end of the : string
and then restart the same iteration for the next :.
This fix breaks the usename and password detection when it encounters the next : thus breaking the look early
and backtracking less.

* Adding a test case for a valid URL between colons

url-detector/pom.xml

@@ -4,7 +4,7 @@
 
   <groupId>com.linkedin.urls</groupId>
   <artifactId>url-detector</artifactId>
-  <version>0.2.1-alpha</version>
+  <version>0.2.2-alpha</version>
   <packaging>jar</packaging>
 
   <name>com.linkedin.urls:url-detector</name>

url-detector/src/main/java/com/linkedin/urls/detection/UrlDetector.java

@@ -491,7 +491,7 @@ private boolean readUserPass(int beginningOfUsername) {
         //everything is still ok, just remember that we found a dot or '[' in case we might need to backtrack
         _buffer.append(curr);
         rollback = true;
-      } else if (curr == '#' || curr == ' ' || curr == '/'
+      } else if (curr == '#' || curr == ' ' || curr == '/' || curr ==':'
           || checkMatchingCharacter(curr) != CharacterMatch.CharacterNotMatched) {
         //one of these characters indicates we are invalid state and should just return.
         rollback = true;

url-detector/src/test/java/com/linkedin/urls/detection/TestUriDetection.java

@@ -644,6 +644,23 @@ public void testIpv6ZoneIndicesWithUrlEncodedDots(String address, String zoneInd
     runTest(validUrl, UrlDetectorOptions.Default, validUrl);
   }
 
+  @Test
+  public void testColonEmbededurl() {
+   runTest("::::::::::::::::::::::http://username:[email protected]:::::::::::::::",
+    UrlDetectorOptions.Default, "http://username:[email protected]");
+  }
+  @Test
+  public void testNegativeArraySizeException() {
+    String rawtext = "How ::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::\\n\\nCome ";
+    List<Url> urls = null;
+    try {
+      UrlDetector detector = new UrlDetector(rawtext, UrlDetectorOptions.Default);
+      urls = detector.detect();
+    } catch (NegativeArraySizeException e ) {
+      Assert.fail(e.getMessage());
+    }
+  }
+
   @Test
   public void testBacktrackInvalidUsernamePassword() {
     runTest("http://hello:asdf.com", UrlDetectorOptions.Default, "asdf.com");