Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ORPO] add nll_target for orpo nll loss #503

Merged
merged 11 commits into from
Jan 9, 2025
Merged

[ORPO] add nll_target for orpo nll loss #503

merged 11 commits into from
Jan 9, 2025
+82 −33

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Dec 29, 2024 •
edited
Loading

Summary

add optional nll_target argument to calculate nll (needed for ORPO nll loss)

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@kashif kashif mentioned this pull request Dec 29, 2024
Open
austin362667
austin362667 previously approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@austin362667 austin362667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed, thank you! @kashif

austin362667
austin362667 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@austin362667 austin362667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @kashif

@austin362667 austin362667 merged commit 9586a87 into linkedin:main Jan 9, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austin362667 austin362667 austin362667 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kashif @austin362667