Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfigProvider SPI and K8s implementation to load ConfigMap resources #80

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

jogrogan
Copy link
Collaborator

@jogrogan jogrogan commented Jan 7, 2025

Add ConfigProvider SPI and K8s implementation to load ConfigMap resources

  • Add ConfigProvider specifically for K8s to load ConfigMap objects
  • Load these configs at the driver level where needed

@jogrogan jogrogan force-pushed the jogrogan/configMap branch 3 times, most recently from 7235865 to cfd9df8 Compare January 7, 2025 21:20
@jogrogan jogrogan force-pushed the jogrogan/configMap branch from cfd9df8 to acfbc87 Compare January 7, 2025 22:46
@jogrogan jogrogan changed the title Add loading of K8s ConfigMap on Driver startup Add ConfigProvider SPI and K8s implementation to load ConfigMap resources Jan 7, 2025
Copy link
Collaborator

@ryannedolan ryannedolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Couple notes but not blocking.

@jogrogan jogrogan merged commit 3a552a7 into main Jan 8, 2025
1 check passed
@jogrogan jogrogan deleted the jogrogan/configMap branch January 8, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants