Lint fix

linkedin · Dec 23, 2024 · b03034b · b03034b
1 parent 502501f
commit b03034b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -55,7 +55,7 @@ linters-settings:
       - name: time-naming
       - name: unexported-return
       - name: indent-error-flow
-      - name: errorf    
+      - name: errorf
       - name: empty-block
       - name: superfluous-else
       # - name: unused-parameter
@@ -83,7 +83,7 @@ linters:
     - ineffassign
     - misspell
     - nakedret
-    - exportloopref
+    - copyloopvar
     - staticcheck
     # - structcheck
     - stylecheck

diff --git a/core/internal/helpers/sarama_test.go b/core/internal/helpers/sarama_test.go
@@ -65,7 +65,7 @@ func TestInitSaramaLogging(t *testing.T) {
 func shouldPanicForVersion(t *testing.T, v string) {
 	defer func() { recover() }()
 	out := parseKafkaVersion(v)
-	t.Errorf("Kafka version " + v + " should have panicked, but got: " + out.String())
+	t.Errorf("Kafka version %s should have panicked, but got: %s", v, out.String())
 }
 
 func TestVersionMapping(t *testing.T) {

diff --git a/core/internal/helpers/zookeeper.go b/core/internal/helpers/zookeeper.go
@@ -88,7 +88,7 @@ func newTLSDialer(addr, caFile, certFile, keyFile string) (zk.Dialer, error) {
 		RootCAs: caCertPool,
 	}
 
-	if len(certFile) > 0 && len(keyFile) > 0 {
+	if certFile != "" && keyFile != "" {
 		cert, err := tls.LoadX509KeyPair(certFile, keyFile)
 		if err != nil {
 			return nil, errors.New("cannot read TLS certificate or key file: " + err.Error())