-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for dashboard- and chart-level workflow links #232
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e55ba9a
idk something like this
MisterSquishy e4de3bd
`Merge remote-tracking branch 'origin/main' into workflow_links
MisterSquishy 1f9f3b2
test?
MisterSquishy 752e0a5
sick
MisterSquishy 337bb05
verz
MisterSquishy 104ca68
added terraform docs
MisterSquishy 0c41667
dont work so hard
MisterSquishy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
1.96.0 | ||
1.97.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this whole
[]any
business? 🧐There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type casting with an unexpected shape?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that d.Get function is getting the list of workflow links from the terraform state -- but all we told terraform is the schema, so it doesnt have a strongly-typed representation of the data
im honestly not totally sure why we traditionally cast to
[]any
first, and then do a subsequent cast (down here) to get the elements of the array as maps. i think maybe i dont like that pattern and im gonna break it here?? let's see how this goes...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 all for seeing how it goes in the face of uncertainty 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it did not go great 😂
i guess go makes you cast in two steps??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExYnVwZmUzcnZpcnN6cTl0dnJqaXhtcDY3aHZrbDZyaHE4eHA5d21kayZlcD12MV9naWZzX3NlYXJjaCZjdD1n/FzXa3cs6ux2so/giphy.gif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even just this doesnt work -- i guess generic arrays and maps omit type info, so their elements must be cast individually 😞
![CleanShot 2024-08-08 at 14 40 15@2x](https://private-user-images.githubusercontent.com/5599894/356341219-cf76bae3-91d2-4511-baf2-3c84564a9e04.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNzYxMjIsIm5iZiI6MTczOTE3NTgyMiwicGF0aCI6Ii81NTk5ODk0LzM1NjM0MTIxOS1jZjc2YmFlMy05MWQyLTQ1MTEtYmFmMi0zYzg0NTY0YTllMDQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTBUMDgyMzQyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmI2YWNiNDU1ZjIwZGYwMTkyM2I4NTcxNjE3MzI0ZWRkY2Q1ZmIwZDEyY2RiYmUyY2Y3MjFjM2M4ZDdhOGJhMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.OPTSzPTLIYXz7QAp6kTan4Dxof5PTHaS68u-8sdlnJI)