Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a latent bug in composite alerts, in which a drop-and-recreate of a subalert causes an OOB panic:
this bug seems to have been latent since composite alert support was introduced in #144; we appear to have noticed it but it went unfixed.
this PR is not a perfect fix; it is still unclear to me why a change to
hidden_queries
triggers a drop-and-recreate of an entirealert
object (but a change to, say,query_string
does not), or why a drop-and-recreate would show up as an emptyalert
object in the list. but this seems like the quickest way out of this mess