fix unresolvable hidden_queries
diff
#224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we added support for hidden_queries, we decided to omit the name of the outer query from state, and instead default it in using the value of the query-level
hidden
attribute. this neglected to account for the case when the user includes the name of the outer query in the map explicitly in HCL, which yields an unresolvable diff -- the provider thinks it needs to add the outer query name to state, but then refuses to actually add it on apply.instead, as of this PR we will start tracking the outer query's
hidden_queries
entry in state (matching whatever the user has added in their HCL), and no longer default the value of the outer query's hidden state. the UI already uses the overallhidden
value if the outer query's name is not specified inhidden_queries
, so there's no need to set it explicitly here