Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unresolvable hidden_queries diff #224

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

MisterSquishy
Copy link
Contributor

@MisterSquishy MisterSquishy commented May 20, 2024

when we added support for hidden_queries, we decided to omit the name of the outer query from state, and instead default it in using the value of the query-level hidden attribute. this neglected to account for the case when the user includes the name of the outer query in the map explicitly in HCL, which yields an unresolvable diff -- the provider thinks it needs to add the outer query name to state, but then refuses to actually add it on apply.

instead, as of this PR we will start tracking the outer query's hidden_queries entry in state (matching whatever the user has added in their HCL), and no longer default the value of the outer query's hidden state. the UI already uses the overall hidden value if the outer query's name is not specified in hidden_queries, so there's no need to set it explicitly here

@MisterSquishy MisterSquishy requested a review from danhurwit May 20, 2024 17:21
@MisterSquishy MisterSquishy requested a review from a team May 21, 2024 14:23
@MisterSquishy MisterSquishy merged commit d858e7a into main May 23, 2024
6 checks passed
@MisterSquishy MisterSquishy deleted the fix_hiddenquery_diff branch May 23, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants