Fix spurious diff with hidden_queries
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterSquishy
commented
May 3, 2024
| } | ||
| hq := make(map[string]interface{}, len(query.HiddenQueries)) | ||
| for k, v := range query.HiddenQueries { | ||
| // Don't include the top-level query in the TF resource data |
There was a problem hiding this comment.
note that this leads to another unresolvable diff scenario, specifically when the user specifies a hidden_queries with the top-level query name included (because the HCL will keep trying to add it, and this code will keep omitting it). i am choosing not to fix this in the provider, because i dont know how i think the API should be updated to better handle this case -- in particular, we should omit the top-level query name from hidden_queries in the API, and use hidden for that purpose (as the contract has been defined here)
danhurwit
approved these changes
May 3, 2024
| } | ||
| hq := make(map[string]interface{}, len(query.HiddenQueries)) | ||
| for k, v := range query.HiddenQueries { | ||
| // Don't include the top-level query in the TF resource data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a spurious diff issue, in which alerts with
hidden_queriesset will continuously try (and fail) to "update". This is caused by a failure to store thehidden_queriesmap in state, causing an unresolvable diff between the HCL and the state file.I fixed this by stealing the
hidden_queriessetting code fromlightstep_dashboardand calling it fromlightstep_alert, and added a unit test to ensure the plan is clean for these types of alerts now