Add snooze rules resource #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambcode
commented
Mar 26, 2024
| @@ -38,6 +38,6 @@ Documentation files in `docs` are generated by combining: | |||
| Any edits to documentation files should be made in the `templates` directory or the .go files. Then you can use the following steps to generate the files in the docs directory: | |||
|
|
|||
| 1. Download `tfplugindocs` from https://github.com/hashicorp/terraform-plugin-docs/releases and make it available on your `PATH` | |||
| 2. Run `$ make docs` or `$ tfplugindocs` from the root of this directory | |||
There was a problem hiding this comment.
Running tfplugindocs directly doesn't work anymore because tfplugindocs builds the provider with the registry.terraform.io prefix, but then calls the terraform binary which is now open-tofu that looks for plugins with the prefix of registry.opentofu.org.
lambcode
commented
Mar 26, 2024
| tfplugindocs | ||
| docs: build | ||
| $(MAKE) -C tfplugindocs_working generate-schema | ||
| tfplugindocs generate --providers-schema tfplugindocs_working/schema.json |
There was a problem hiding this comment.
Now we generate the schema separately from generating the docs to allow us bypass the tfplugindocs auto compiling the provider.
lambcode
force-pushed
the
blamb/snoozerules
branch
from
3c9284e to
572075d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds snooze rules as a resource to the terraform provider.
Note that I had to fix how we generate docs now that we have tofu as our terraform binary. The docs can still be created via the
make docscommand, and should now be agnostic to whether you have terraform or tofu installed.@lightstep/team-alerts-be