Add event query ids #207
Merged
Add event query ids #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhurwit
force-pushed
the
add-event-query-ids
branch
from
3b74887 to
0275e99
Compare
MisterSquishy
approved these changes
Feb 12, 2024
.go-version
Outdated
| 1.89.1 |
There was a problem hiding this comment.
additive changes get a minor bump, no?
Suggested change
| 1.89.1 | |
| 1.90.0 |
There was a problem hiding this comment.
Yeah just caught that
| project_name = "` + testProject + `" | ||
| dashboard_name = "Acceptance Test Dashboard (TestAccDashboardServiceHealthPanel)" | ||
| dashboard_description = "Dashboard to test the service health panel" | ||
| event_query_ids = [] |
There was a problem hiding this comment.
ffti but id also be interested to document what happens when
- you try to link a dashboard to a nonexistent event query id
- you try to delete an event query that is still referenced by a dashboard
danhurwit
force-pushed
the
add-event-query-ids
branch
from
fb6c662 to
31561f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds event_query_ids field to dashboards as well as the event_query resource type.
Automates the generation of docs because that step always seems to be broken.