deprecate environment in favor of api_url #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettbuddin
reviewed
Feb 12, 2024
|
@brettbuddin stil very much a work in progress but thanks for the review! i'm currently struggling with the acceptance tests / doc generation 😕 |
matthagenbuch
force-pushed
the
matth.api_url
branch
from
c9f528e to
31ddd36
Compare
brettbuddin
reviewed
Feb 12, 2024
brettbuddin
reviewed
Feb 12, 2024
brettbuddin
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to add support for provisioning resources in the new EU instances. Currently, the provider accepts an
environmentparameter which must be public|meta|staging , and we construct the API URL based on this.To make this change, I deprecated the environment parameter and added an
api_urlparameter which always takes precedence. If neither is provided, it defaults to the US public instance (as it does today). Terraform will display a deprecation warning for those using the provider with the environment parameter, and we would eventually remove it.