fix hidden_queries plan bug #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterSquishy
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
weirdddd how was this test working without a ExpectNonEmptyPlan? did we add handling for this in dashboards but forget about alerts?
either way maybe worth an analogous test in alerts!
|
oh also dont forget to update |
matthagenbuch
added a commit
that referenced
this pull request
Jan 17, 2024
This reverts commit 8a92fc0.
matthagenbuch
added a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when using the
lightstep_alert.query.hidden_queriesattribute. Currently, if this attribute is set the plan will always show a change because it isn't being read during the refresh stage. This change reads the hidden_queries into the resource during refresh, resulting in a clean plan.