[LS-53603] terraform support for service health panel #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealAkhil
changed the title
TheRealAkhil
changed the title
TheRealAkhil
requested review from
danhurwit,
DHedgecock,
i-xin and
amburvill
|
I'm sending this out for early review. I still need to add tests, update docs, verify behavior locally, etc. Thanks for taking a look! |
TheRealAkhil
commented
Nov 8, 2023
| @@ -57,6 +58,14 @@ type Label struct { | |||
| Value string `json:"label_value"` | |||
| } | |||
|
|
|||
| type Panel struct { | |||
There was a problem hiding this comment.
this matches the publicapi implementation
amburvill
reviewed
Nov 8, 2023
amburvill
reviewed
Nov 8, 2023
… the acceptance tests
amburvill
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the service health panel in the Lightstep terraform provider.
Pre-merge checklist
R/CC