replace label point with string and remove short circuit

lightstep · Jun 24, 2024 · 56baf3b · 56baf3b
1 parent 2173d00
commit 56baf3b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/client/metric_dashboards.go b/client/metric_dashboards.go
@@ -73,8 +73,8 @@ type Threshold struct {
 	Operator string  `json:"operator"`
 	Value    float64 `json:"value"`
 	// An alpha hex color
-	Color string  `json:"color"`
-	Label *string `json:"label"`
+	Color string `json:"color"`
+	Label string `json:"label"`
 }
 
 type YAxis struct {

diff --git a/lightstep/resource_metric_dashboard.go b/lightstep/resource_metric_dashboard.go
@@ -629,11 +629,7 @@ func buildChartThresholds(thresholdsIn []interface{}) ([]client.Threshold, error
 			return []client.Threshold{}, fmt.Errorf("missing required attribute 'operator' for threshold")
 		}
 
-		label, ok := threshold["label"].(string)
-
-		if !ok {
-			return []client.Threshold{}, fmt.Errorf("missing required attribute 'label' for threshold")
-		}
+		label := threshold["label"].(string)
 
 		value, ok := threshold["value"].(float64)
 
@@ -643,7 +639,7 @@ func buildChartThresholds(thresholdsIn []interface{}) ([]client.Threshold, error
 
 		thresholds = append(thresholds, client.Threshold{
 			Color:    color,
-			Label:    &label,
+			Label:    label,
 			Operator: operator,
 			Value:    value,
 		})