fix composite alerts

lightstep · Jan 3, 2024 · 5386279 · 5386279
1 parent 7c39eed
commit 5386279
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/lightstep/resource_alert.go b/lightstep/resource_alert.go
@@ -68,7 +68,7 @@ func getCompositeAlertFromUnifiedConditionResourceData(compositeAlertIn *client.
 		if subAlertIn.Expression.NoDataDurationMs != nil {
 			subAlertExpressionMap["no_data_duration_ms"] = subAlertIn.Expression.NoDataDurationMs
 		}
-		subAlerts = append(subAlerts, map[string]interface{}{})
+		subAlerts = append(subAlerts, subAlertExpressionMap)
 	}
 
 	return []map[string][]map[string]interface{}{{

diff --git a/lightstep/resource_metric_condition.go b/lightstep/resource_metric_condition.go
@@ -341,7 +341,6 @@ func getThresholdSchemaMap() map[string]*schema.Schema {
 		"critical_duration_ms": {
 			Type:        schema.TypeInt,
 			Optional:    true,
-			Default:     false,
 			Description: "Critical threshold must be breached for this duration before the status changes.",
 		},
 		"warning": {
@@ -352,7 +351,6 @@ func getThresholdSchemaMap() map[string]*schema.Schema {
 		"warning_duration_ms": {
 			Type:        schema.TypeInt,
 			Optional:    true,
-			Default:     false,
 			Description: "Critical threshold must be breached for this duration before the status changes.",
 		},
 	}
@@ -437,7 +435,6 @@ func getCompositeSubAlertExpressionResource() *schema.Resource {
 			"no_data_duration_ms": {
 				Type:        schema.TypeInt,
 				Optional:    true,
-				Default:     false,
 				Description: "No data must be seen for this duration before the status changes.",
 			},
 			"operand": {