Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

feat: migration to setup-kalix-action #11

Merged
merged 1 commit into from
Feb 21, 2024
Merged

feat: migration to setup-kalix-action #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/node-build-test-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ jobs:
with:
push: true
tags: ${{ secrets.DOCKERHUB_USERNAME }}/person:${{ env.PERSON_VERSION }}
- name: Kalix Deploy
uses: lightbend/kalix-action@v7
- name: Install Kalix CLI
uses: lightbend/setup-kalix-action@v1
with:
cmd: "services deploy person ${{ secrets.DOCKERHUB_USERNAME }}/person:${{ env.PERSON_VERSION }}"
env:
token: ${{ secrets.KALIX_TOKEN }}
project: ${{ secrets.KALIX_PROJECT_ID }}
project-id: ${{ vars.KALIX_PROJECT_ID }}
- name: Kalix Deploy
run: kalix services deploy person ${{ secrets.DOCKERHUB_USERNAME }}/person:${{ env.PERSON_VERSION }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should possibly assume using the Kalix Container Registry?
But we could go with this to start with.

Copy link
Contributor Author

@aludwiko aludwiko Feb 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can go with KCR, but that would require more changes, let's do this separately

Loading