-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbortSignal support #69
base: master
Are you sure you want to change the base?
Conversation
@BerkliumBirb thank you for the improvement and especially thank you for the testcase and doc updates too! Due to some security requirements we have, all our projects require signed commits. Do you mind re-pushing your commits with signatures? If you don't want to do that, I can re-create your changes and merge. The downside is that you won't get "credit" for the commits. |
@BerkliumBirb P.S. after I approved the automation run, I see that it failed with a missing reference |
Wasn't able to find some reputable solution from core-js for example. Wasn't able to pass node arguments through nyc too.
|
I appreciate the time you put into this. The need to add a polyfill for tests concerns me a little bit. Does the addition of AbortSignal bump up the Node.js requirements to >= v16? If so, we should mark the change as a breaking change. I can push a new commit to this branch to do that. |
This polyfill is only used in tests, and the actual code doesn't use anything global. We can ditch the whole I also don't really think this feature deserves a major bump, but if you think it does, we can go that way. So, we have 4 options:
Which one should we go? |
No description provided.