Test for draw when parsing a pgn before assuming resignation #16965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
reviewed
Feb 12, 2025
| @@ -48,7 +48,9 @@ val parseImport: PgnStr => Either[ErrorStr, ImportResult] = pgn => | |||
| .map(Fen.write) | |||
|
|
|||
| val status = parsed.tags(_.Termination).map(_.toLowerCase) match | |||
| case Some("normal") => game.situation.status | Status.Resign | |||
| case Some("normal") => | |||
| game.situation.status | (if parsed.tags(_.Result).getOrElse("") === "1/2-1/2" then Status.Draw | |||
There was a problem hiding this comment.
.getOrElse("") === "1/2-1/2" == .contains("1/2-1/2")
There was a problem hiding this comment.
also this is not the place to hardcode the draw notation, scalachess has parsers and they account for many other draw notations such as ½-½ or 0.5-0.5
There was a problem hiding this comment.
You mean that the issue is that game.situation.status should be Status.Draw and that should be fixed in scalachess ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16951