Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show correct max. number of games for multi PGN import #16922

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

jelmis
Copy link
Contributor

@jelmis jelmis commented Feb 4, 2025

Issue #16921

In a lichess study, the PGN import functionality allows for 64 games to be imported in one go. However, the import description states 32 as the max. number.

Fix

image

@yafred
Copy link
Contributor

yafred commented Feb 4, 2025

I was just about to create a PR too 😄

I would have changed the message to: Paste your PGN text here. Each game is a new chapter. The study can have up to 64 chapters

yafred@4ad0651

@jelmis
Copy link
Contributor Author

jelmis commented Feb 5, 2025

@yafred Good idea to improve the message! I like your version and would suggest to tweak it just a little:

Paste your PGN text here (one or multiple games). For each game, a new chapter is created. The study can have up to 64 chapters.

Reasoning: Since the user gets to see the message right after clicking

+ Add a new chapter (i.e. a single chapter)

they might find it helpful to have it explained more explicitly that pasting more than one game is (a) possible, and (b) will lead to the automatic creation of more than just a single chapter.

WDYT? If my suggestion is too verbose, feel free to just ditch this PR and proceed with yours 🌱

@yafred
Copy link
Contributor

yafred commented Feb 5, 2025

Yes, I agree with your point.
When you create a chapter and import one game, it's very clear.
When you create a chapter and import multiple games that will become chapters ... it's getting confusing the first time you do it.

I think the message was inaccurate (not only the number ... good catch by the way)
My PR was accepted
If you find a better wording, keep your PR open.
But, yes, be careful about verbosity

This makes me think that we could add a comment for translators a with a sensible explanation

<plurals name="pasteYourPgnTextHereUpToNbGames" comment="Keep it short ... " >

If not, you can close the PR

@jelmis
Copy link
Contributor Author

jelmis commented Feb 5, 2025

Thanks for your thoughts! I've

  • shortened the help message to: "Paste games as PGN text here. For each game, a new chapter is created. The study can have up to 64 chapters."
  • added a comment for translators:"It is possible to create multiple chapters in one go. Please try to convey this using a short translation."

Will leave this PR open for now.

@ornicar ornicar merged commit 0f02fdb into lichess-org:master Feb 5, 2025
6 checks passed
@superuser-does
Copy link
Collaborator

@jelmis @yafred For awareness, this comment did not go through to our translation platform, Crowdin.

Crowdin ignores comment attributes to <plurals>. They are not sent from Crowdin to git, nor are they indexed when they are in our source code (like in this case).

I have updated the comment for you on Crowdin's side. For future reference you can write to one of the translation managers at Crowdin if you'd like a specific context to be changed. With that said, we try to pick them up as updates are made so you don't need to go out of your way to do this in the code.

@jelmis jelmis deleted the multi-pgn-import-description branch February 6, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants