-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show correct max. number of games for multi PGN import #16922
Show correct max. number of games for multi PGN import #16922
Conversation
I was just about to create a PR too 😄 I would have changed the message to: Paste your PGN text here. Each game is a new chapter. The study can have up to 64 chapters |
@yafred Good idea to improve the message! I like your version and would suggest to tweak it just a little:
Reasoning: Since the user gets to see the message right after clicking
they might find it helpful to have it explained more explicitly that pasting more than one game is (a) possible, and (b) will lead to the automatic creation of more than just a single chapter. WDYT? If my suggestion is too verbose, feel free to just ditch this PR and proceed with yours 🌱 |
Yes, I agree with your point. I think the message was inaccurate (not only the number ... good catch by the way) This makes me think that we could add a comment for translators a with a sensible explanation
If not, you can close the PR |
Thanks for your thoughts! I've
Will leave this PR open for now. |
@jelmis @yafred For awareness, this comment did not go through to our translation platform, Crowdin. Crowdin ignores I have updated the comment for you on Crowdin's side. For future reference you can write to one of the translation managers at Crowdin if you'd like a specific context to be changed. With that said, we try to pick them up as updates are made so you don't need to go out of your way to do this in the code. |
Issue #16921
In a lichess study, the PGN import functionality allows for 64 games to be imported in one go. However, the import description states 32 as the max. number.
Fix