Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompting your preferred game format when challenged #16912

Closed
wants to merge 12 commits into from

Conversation

yafred
Copy link
Contributor

@yafred yafred commented Feb 3, 2025

A new tab in preferences allows user A to create/edit one challenge preference using the existing challenge dialog.

When user B accesses the profile of user A, the 'challenge to a game link' is overridden to carry user A preference.
(In this case, user B stored preferences are not changed)

User A can also copy and paste his challenge link for share it.

Benefits: the challenge link carries only one attribute (challenge-pref) for everything. It may supersedes the forcedOptions where attributes are added one at a time. Obviously, the user cannot write the URL manually but needs to use the challenge preference page.

Ideas for the future:

  • Shortening the url when it is shared (for ex: /challenge/:key would redirect to /?user=xx&challenge-pref=xxxx#friend)
  • Save more than one preference to enable/disable them (this is why I create a new collection in DB)
  • Generate links to share for other situations; ai, challenge a user
  • Allow the dialog to propose more than one type of challenge
  • Enforce the preference(s) server side so that the challenge is refused if not the preference

@yafred yafred marked this pull request as ready for review February 3, 2025 08:14
@kraktus
Copy link
Member

kraktus commented Feb 3, 2025

Hey yafred, thanks for the good work but are sure this is solving a user issue? I've never seen anything like that be requested

@yafred
Copy link
Contributor Author

yafred commented Feb 3, 2025

At first, it was an idea I had watching how streamers were using Lichess

And then I found this issue #14305 and especially the comment in the PR #16004

It remains very obscure and niche, eventually we need an UI that generates these URLs

@yafred
Copy link
Contributor Author

yafred commented Feb 3, 2025

I learn a lot doing that ... I won't be offended if it is closed off-topic or not planned 😃

@yafred yafred marked this pull request as draft February 3, 2025 17:48
@yafred yafred closed this Feb 4, 2025
@yafred yafred deleted the challenge-prefs branch February 4, 2025 13:23
@yafred yafred restored the challenge-prefs branch February 6, 2025 00:52
@yafred yafred deleted the challenge-prefs branch February 6, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants