Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docs about the possibility of Perls below 5.8 #47

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

petdance
Copy link
Contributor

@petdance petdance commented Aug 5, 2024

HTML::Parser requires Perl 5.8, so the documentation about Perls below 5.6 or 5.8 are not necessary.

Copy link
Member

@oalders oalders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@oalders oalders merged commit ad308e4 into libwww-perl:master Aug 5, 2024
9 checks passed
@petdance
Copy link
Contributor Author

petdance commented Aug 5, 2024

There's code in HTML::Entities that does similar run-time checking, like

 ( $] > 5.007 ? (
  'OElig;'    => chr(338),
  'oelig;'    => chr(339),
  'Scaron;'   => chr(352),
  'scaron;'   => chr(353),

Do we want to make similar changes there? If so, I'll make a seaprate PR for it.

@oalders
Copy link
Member

oalders commented Aug 5, 2024

A PR would be great!

@petdance
Copy link
Contributor Author

petdance commented Aug 5, 2024

Will do. Just wanted to make sure that we weren't going to want to split out HTML::Entities or something.

@oalders
Copy link
Member

oalders commented Aug 5, 2024

I don't know of any plans to split out HTML::Entities, so I don't think we need to worry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants