Issue 10 website news tab causes download #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo fix in ck_assert_str_eq documentation
Update some download links from sourceforge to github.
Fix title of web/install.html.
As the related issue documents, GitHub pages cannot determine the file type of the NEWS or LGPL files because they do not have a file extension, so the server uses a default MIME type of application/octet-stream, which triggers a download, rather than letting the user actually read the file. To circumvent this problem, I changed to file links from relative links to full hyperlinks referencing the GitHub repository URL instead. The NEWS file is now viewable via the "raw" view option accessible through GitHub, and the LGPL file links to the GitHub license file default. I chose not to simply use the raw view for the license file since I felt most people looking at that file would probably not be lawyers, and would therefore benefit from the summary GitHub displays at the top of the page. This pull request fixes issue libcheck#10
jflopezfernandez
deleted the
issue-10-website-NEWS-tab-causes-download
branch
jflopezfernandez
restored the
issue-10-website-NEWS-tab-causes-download
branch
|
This pull request sought to merge the changes to the master branch instead of the GitHub pages branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit
As the related issue documents, GitHub pages cannot
determine the file type of the NEWS or LGPL files because
they do not have a file extension, so the server uses a
default MIME type of application/octet-stream, which
triggers a download, rather than letting the user actually
read the file.
To circumvent this problem, I changed to file links from
relative links to full hyperlinks referencing the GitHub
repository URL instead. The NEWS file is now viewable via
the "raw" view option accessible through GitHub, and the
LGPL file links to the GitHub license file default.
I chose not to simply use the raw view for the license file
since I felt most people looking at that file would
probably not be lawyers, and would therefore benefit from
the summary GitHub displays at the top of the page.
Notes
I tested the links using the Firefox web developer tools.
This pull request fixes issue #10