Merge pull request #89 from RyDroid/vera-fix

Fixing "errors" reported by vera++
libcheck · Dec 15, 2016 · b2f4662 · b2f4662
2 parents 24cd68c + 600aef4
commit b2f4662
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 17 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -47,9 +47,9 @@ matrix:
 script:
   - mkdir build
   - cd build
-  - if [ $USE_CMAKE == "YES" ] ; then cmake ../ ; fi
-  - if [ $USE_CMAKE == "NO" ] ; then pushd ../ ; autoreconf -i ; popd; fi
-  - if [ $USE_CMAKE == "NO" ] ; then ../configure ; fi
+  - if [ $USE_CMAKE == 'YES' ] ; then cmake .. ; fi
+  - if [ $USE_CMAKE == 'NO' ] ; then pushd .. ; autoreconf -i ; popd; fi
+  - if [ $USE_CMAKE == 'NO' ] ; then ../configure ; fi
   - make
-  - if [ $USE_CMAKE == "YES" ] ; then CTEST_OUTPUT_ON_FAILURE=1 make test ; fi
-  - if [ $USE_CMAKE == "NO" ] ; then make check ; fi
+  - if [ $USE_CMAKE == 'YES' ] ; then CTEST_OUTPUT_ON_FAILURE=1 make test ; fi
+  - if [ $USE_CMAKE == 'NO' ] ; then make check ; fi
diff --git a/src/check.c b/src/check.c
@@ -259,7 +259,8 @@ void _tcase_add_test(TCase * tc, TFun fn, const char *name, int _signal,
     tf->loop_start = start;
     tf->loop_end = end;
     tf->signal = _signal;       /* 0 means no signal expected */
-    tf->allowed_exit_value = (WEXITSTATUS_MASK & allowed_exit_value);   /* 0 is default successful exit */
+    tf->allowed_exit_value =
+      (WEXITSTATUS_MASK & allowed_exit_value);   /* 0 is default successful exit */
     tf->name = name;
     check_list_add_end(tc->tflst, tf);
 }

diff --git a/src/check_log.c b/src/check_log.c
@@ -289,12 +289,12 @@ void xml_lfun(SRunner * sr CK_ATTRIBUTE_UNUSED, FILE * file,
     switch (evt)
     {
         case CLINITLOG_SR:
-            fprintf(file, "<?xml version=\"1.0\"?>\n");
             fprintf(file,
-                    "<?xml-stylesheet type=\"text/xsl\" href=\"http://check.sourceforge.net/xml/check_unittest.xslt\"?>\n");
-            fprintf(file,
-                    "<testsuites xmlns=\"http://check.sourceforge.net/ns\">\n");
-            fprintf(file, "  <datetime>%s</datetime>\n", t);
+		    "<?xml version=\"1.0\"?>\n"
+		    "<?xml-stylesheet type=\"text/xsl\" "
+		    "href=\"http://check.sourceforge.net/xml/check_unittest.xslt\"?>\n"
+		    "<testsuites xmlns=\"http://check.sourceforge.net/ns\">\n"
+		    "  <datetime>%s</datetime>\n", t);
             break;
         case CLENDLOG_SR:
         {
@@ -304,17 +304,19 @@ void xml_lfun(SRunner * sr CK_ATTRIBUTE_UNUSED, FILE * file,
             /* calculate time the test were running */
             clock_gettime(check_get_clockid(), &ts_end);
             duration = (unsigned long)DIFF_IN_USEC(ts_start, ts_end);
-            fprintf(file, "  <duration>%lu.%06lu</duration>\n",
+            fprintf(file,
+		    "  <duration>%lu.%06lu</duration>\n"
+		    "</testsuites>\n",
                     duration / US_PER_SEC, duration % US_PER_SEC);
-            fprintf(file, "</testsuites>\n");
         }
             break;
         case CLSTART_SR:
             break;
         case CLSTART_S:
             s = (Suite *)obj;
-            fprintf(file, "  <suite>\n");
-            fprintf(file, "    <title>");
+            fprintf(file,
+		    "  <suite>\n"
+		    "    <title>");
             fprint_xml_esc(file, s->name);
             fprintf(file, "</title>\n");
             break;

diff --git a/src/check_pack.c b/src/check_pack.c
@@ -33,7 +33,7 @@
 #ifndef HAVE_PTHREAD
 #define pthread_mutex_lock(arg)
 #define pthread_mutex_unlock(arg)
-#define pthread_cleanup_push(f,a) {
+#define pthread_cleanup_push(f, a) {
 #define pthread_cleanup_pop(e) }
 #endif
 

diff --git a/src/check_run.c b/src/check_run.c
@@ -505,7 +505,7 @@ static TestResult *tcase_run_tfun_fork(SRunner * sr, TCase * tc, TF * tfun,
     alarm_received = 0;
 
     if(timer_create(check_get_clockid(),
-                    NULL /* fire SIGALRM if timer expires */ ,
+                    NULL /* fire SIGALRM if timer expires */,
                     &timerid) == 0)
     {
         /* Set the timer to fire once */