Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make settings virtual, remove dead code. #261

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Make settings virtual, remove dead code. #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29430af
Make settings virtual.
evoskuil Feb 7, 2023
6b74037
Remove dead test setup code.
evoskuil Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/bitcoin/protocol/settings.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ namespace protocol {
/// Common protocol configuration settings, properties not thread safe.
struct BCP_API settings
{
DEFAULT_COPY_MOVE_DESTRUCT(settings);

settings() NOEXCEPT;
settings(uint32_t send_high_water, uint32_t receive_high_water) NOEXCEPT;

Expand Down
5 changes: 0 additions & 5 deletions test/test.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@
#define TEST_PATH \
TEST_DIRECTORY + "/" + TEST_NAME

#ifdef _MSC_VER
#define NO_GLOBAL_INIT_CALLS 26426
#define NO_UNUSED_LOCAL_SMART_PTR 26414
#endif

#ifdef _MSC_VER
BC_DISABLE_WARNING(NO_ARRAY_INDEXING)
BC_DISABLE_WARNING(NO_GLOBAL_INIT_CALLS)
Expand Down
Loading