Fixed a few arrays.

lextudio · Nov 7, 2010 · 7538e7b · 7538e7b
1 parent 787dbb5
commit 7538e7b
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/Browser/ModuleListPanel.cs b/Browser/ModuleListPanel.cs
@@ -118,6 +118,8 @@ private void ActAddExecute(object sender, EventArgs e)
             foreach (ListViewItem item in listView1.SelectedItems)
             {
                 string name = item.Text.ToUpperInvariant();
+
+                // TODO: bad performance. improve later.
                 List<string> list = new List<string>(File.ReadAllLines(index));
                 if (list.Contains(name))
                 {
@@ -138,6 +140,8 @@ private void ActRemoveExecute(object sender, EventArgs e)
             foreach (ListViewItem item in listView1.SelectedItems)
             {
                 string name = item.Text.ToUpperInvariant();
+
+                // TODO: bad performance. improve later.
                 List<string> list = new List<string>(File.ReadAllLines(index));
                 if (!list.Contains(name))
                 {

diff --git a/Compiler/MainForm.cs b/Compiler/MainForm.cs
@@ -75,8 +75,7 @@ private void ActCompileExecute(object sender, EventArgs e)
         {
             IDockContent content = dockPanel1.ActiveDocument;
             DocumentPanel doc = (DocumentPanel)content;
-            List<string> fileList = new List<string>(1) { doc.FileName };
-            Compiler.Compile(fileList);
+            Compiler.Compile(new [] { doc.FileName });
         }
 
         private void ActCompileUpdate(object sender, EventArgs e)

diff --git a/SharpSnmpLib/GetRequestPdu.cs b/SharpSnmpLib/GetRequestPdu.cs
@@ -45,7 +45,6 @@ public GetRequestPdu(int requestId, ErrorCode errorStatus, int errorIndex, IList
             ErrorIndex = new Integer32(errorIndex);
             Variables = variables;
             _varbindSection = Variable.Transform(variables);
-            ////_raw = ByteTool.ParseItems(_sequenceNumber, _errorStatus, _errorIndex, _varbindSection);
         }
 
         /// <summary>

diff --git a/SharpSnmpLib/Messaging/SnmpMessageExtension.cs b/SharpSnmpLib/Messaging/SnmpMessageExtension.cs
@@ -63,7 +63,7 @@ internal static Sequence PackMessage(VersionCode version, ISegment header, ISegm
                 throw new ArgumentNullException("privacy");
             }
 
-            List<ISnmpData> collection = new List<ISnmpData>(4)
+            ISnmpData[] collection = new ISnmpData[4]
                                              {
                                                  new Integer32((int)version),
                                                  header.GetData(version),
@@ -95,7 +95,7 @@ internal static Sequence PackMessage(VersionCode version, ISegment header, Secur
                 throw new ArgumentNullException("privacy");
             }
 
-            List<ISnmpData> collection = new List<ISnmpData>(4)
+            ISnmpData[] collection = new ISnmpData[4]
                                              {
                                                  new Integer32((int)version),
                                                  header.GetData(version),

diff --git a/SharpSnmpLib/Variable.cs b/SharpSnmpLib/Variable.cs
@@ -132,6 +132,7 @@ internal static IList<Variable> Transform(Sequence varbindSection)
         /// <returns></returns>
         internal static Sequence Transform(IList<Variable> variables)
         {
+            // TODO: use IEnumerable instead of IList.
             if (variables == null)
             {
                 throw new ArgumentNullException("variables");