Improve string comparison performance #1299
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the comparison is extremely inefficient. As you know
ToLower
is a rather slow operation, which may reduce performance for comparing a large number of strings. The best way is to use overloading withStringComparison
support. But it is not available in Net framework.I added the code and description from .Net 9 to support the method on any target framework. To prevent using from being marked unused in Net core and accidentally deleted, I added global using for extensions in the UI package.
Additionally I removed the
Trim
call, for URI comparison, URI does not support spaces and such call is useless, every call I debugged, everything compares correctly, previous behaviour is preserved with performance increase.Before:
Now:
Benchmark for string
pack://application:,,,/Wpf.Ui;component/Resources/Theme/Light.xaml
:StringComparison.OrdinalIgnoreCase
3 times faster without memory allocation.Pull request type
Please check the type of change your PR introduces: