Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(components): add data-test-ids for e2e tests #870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

THEBOSS0369
Copy link

@THEBOSS0369 THEBOSS0369 commented Jan 4, 2025

Notes for Reviewers

This PR fixes #869

Data Test IDs has been added in components Typography, Button and Input
This PR is created because there weren't Test ids in components which we are using in E2E Tests
This is the PR link where we need these Data Test Ids

Signed commits

  • Yes, I signed my commits.

@SAHU-01
Copy link
Contributor

SAHU-01 commented Jan 5, 2025

Thank you for your contribution @THEBOSS0369
Let's discuss this during the website call on Monday(6th Jan 2025) at 6:30 PM IST

Add it as an agenda item to the meeting minutes, if you would.

@THEBOSS0369
Copy link
Author

Done @SAHU-01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] No Data Test IDs in components
2 participants