external index server in bgworker #355
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage
30 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
var77
force-pushed
the
varik/external-index-bgworker
branch
from
8c40d36 to
e1732ed
Compare
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
| /* ========================================================== */ | ||
|
|
||
| if BackgroundWorker::sighup_received() && !ENABLE_INDEXING_SERVER.get() { | ||
| std::process::exit(1); |
There was a problem hiding this comment.
Why are we exiting with an error code when the external indexing is not enabled?
afaik this causes a postmaster restart, no? is that expected?
There was a problem hiding this comment.
It is because if the bgworker exits with 0 status it won't be restarted automatically and will be unregistered from postmaster. By exiting the process we make sure that any threads created by this process will be killed and as it exits with non-zero code, it will be restarted after the configured bgw_restart_time. After boot it won't start the indexing server (as GUC will be set to false) and will wait for SIGHUP in wait_latch loop, to start in case the lantern_extras.enable_indexing_server will be set to true again.
Ref to docs: https://www.postgresql.org/docs/current/bgworker.html#:~:text=If%20bgw_restart_time%20for,itself%20has%20terminated.
lantern_hnsw/src/hnsw.c
Outdated
| PG_RETURN_NULL(); | ||
| } | ||
|
|
||
| // todo:: remove in 0.4.3 |
There was a problem hiding this comment.
should be 0.5.1 or 0.6.0
lantern_hnsw/src/hnsw/build.c
Outdated
| @@ -486,6 +486,12 @@ static void BuildIndex(Relation heap, Relation index, IndexInfo *indexInfo, ldb_ | |||
|
|
|||
| InitBuildState(buildstate, heap, index, indexInfo); | |||
|
|
|||
| if(buildstate->index_file_path) { | |||
| elog(ERROR, | |||
| "Importing index from file is deprecated.\n" | |||
There was a problem hiding this comment.
deprecated makes it sound like the functionality still exists, but we have removed the functionality already.
Rephrase to "Importing index from file is no longer supported"
var77
force-pushed
the
varik/external-index-bgworker
branch
from
8ca0d74 to
c0dfbbe
Compare
var77
force-pushed
the
varik/external-index-bgworker
branch
from
c0dfbbe to
99625f4
Compare
lantern.external_index_secure=falseby default, so it will correctly connect to background worker.