Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect coverage for lantern_extras using grcov #350

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Oct 31, 2024

No description provided.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@var77 var77 force-pushed the varik/lantern-extras-coverage branch 3 times, most recently from 7573b80 to 45974da Compare October 31, 2024 12:26
Copy link

github-actions bot commented Oct 31, 2024

Benchmarks

metric old new pct change
recall (after create) 0.950 0.951 +0.11%
recall (after insert) 0.000 0.000 -
select tps 13377.926 25215.381 +88.48%
select bulk(100) tps 34.175 35.079 +2.64%
select latency (ms) 0.840 ± 2.124𝜎 0.731 ± 1.663𝜎 -12.98%
select bulk(100) latency (ms) 917.481 ± 177.954𝜎 894.145 ± 110.750𝜎 -2.54%
create latency (ms) 437877.864 418119.195 -4.51%
insert tps 429.893 437.695 +1.81%
insert bulk(100) tps 4.530 4.695 +3.64%
insert latency (ms) 73.901 ± 16.772𝜎 72.411 ± 16.875𝜎 -2.02%
insert bulk(100) latency (ms) 6933.548 ± 108.529𝜎 6643.987 ± 165.924𝜎 -4.18%
disk usage (bytes) 8192008192.000 8192008192.000 -

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@var77 var77 requested a review from Ngalstyan4 October 31, 2024 14:03
@var77 var77 force-pushed the varik/lantern-extras-coverage branch from 45974da to 8d903ac Compare November 3, 2024 12:10
@var77 var77 force-pushed the varik/lantern-extras-coverage branch from 8d903ac to 1250758 Compare November 3, 2024 12:11
@var77 var77 merged commit 11377b1 into main Nov 3, 2024
68 checks passed
@var77 var77 deleted the varik/lantern-extras-coverage branch November 3, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants